[SYCL][Sema] Only imply float size conversion warnings in SYCL #16857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change `-Wimplicit-float-conversion` (part of `-Wconversion`) enabled `-Wimplicit-float-size-conversion` for all language modes. This is problematic because it causes it makes DPC++ emit warnings where upstream clang does not, even when used as a plain C++ compiler. Projects that enable `-Werror` don't expect these (questionable) floating point size warnings when they enable `-Wconversion`, and as such cannot be compiled with the DPC++ compiler. Change `-Wimplicit-float-conversion` to imply `-Wsycl-implicit-float-size-conversion` instead, which is only emitted in SYCL language mode. This preserves existing behaviour for SYCL users. Explicitly passing `-Wimplicit-float-size-conversion` still applies to all language modes. This change only affects users who enable `-Wimplicit-float-conversion` but do not enable `-Wimplicit-float-size-conversion` explicitly and do not compile in SYCL language mode. These users would need to enable the option explicitly to keep the existing behaviour.
Maetveis
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
approved these changes
Feb 2, 2025
|
@intel/dpcpp-cfe-reviewers please review :) |
- Only emit `-Wimplicit-float-size-conversion` warnings in SYCL language mode - Remove `-Wsycl-implicit-float-size-conversion` - Revert changes to llvm community tests - Update tests
Maetveis
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Maetveis
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Simplified the logic now |
I apologize for the delay in review. I was OOO sick last week and am still working on and off now. I think changing the name to include sycl makes sense since this is now a SYCL only warning. |
elizabethandrews
approved these changes
Feb 10, 2025
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
elizabethandrews
approved these changes
Feb 13, 2025
|
I believe the CI failures are unrelated: |
|
@intel/llvm-gatekeepers please merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
-Wimplicit-float-conversion(part of-Wconversion) enabled-Wimplicit-float-size-conversionfor all language modes.This is problematic because it causes DPC++ to emit warnings where upstream clang does not, even when used as a plain C++ compiler. Projects that enable
-Werrordon't expect these (questionable) floating point size warnings when they enable-Wconversion, and as such cannot be compiled with the DPC++ compiler.Change
-Wimplicit-float-conversionto only be emitted in SYCL language mode and rename it to-Wsycl-implicit-float-conversion. This preserves existing behaviour for SYCL users, but otherwise matches upstream Clang behaviour.Fixes: #16393